Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support List/Array in search_sorted(), and fix edge case where length 1 Series of array couldn't use index_of() #21266

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: Support List/Array in search_sorted(), and fix edge case where length 1 Series of array couldn't use index_of() #21266

wants to merge 10 commits into from
+121 −10

Conversation

itamarst
Copy link
Contributor

Fixes #21100

@itamarst itamarst changed the title Fix: Edge case where length 1 Series of array couldn't use index_of() fix: Edge case where length 1 Series of array couldn't use index_of() Feb 14, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Feb 14, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.45%. Comparing base (d922a4b) to head (668ae4a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-ops/src/series/ops/search_sorted.rs 76.92% 3 Missing ⚠️
py-polars/polars/series/series.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #21266      +/-   ##
==========================================
- Coverage   79.52%   79.45%   -0.07%     
==========================================
  Files        1598     1602       +4     
  Lines      230516   230592      +76     
  Branches     2632     2639       +7     
==========================================
- Hits       183309   183211      -98     
- Misses      46600    46769     +169     
- Partials      607      612       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itamarst itamarst marked this pull request as ready for review February 14, 2025 14:22
@itamarst itamarst marked this pull request as draft February 14, 2025 14:23
@itamarst itamarst closed this Feb 14, 2025
@itamarst itamarst reopened this Feb 14, 2025
@itamarst itamarst marked this pull request as ready for review February 14, 2025 14:46
@itamarst
Copy link
Contributor Author

itamarst commented Mar 3, 2025

Going to start on fixing the underlying issue, will resubmit when that's done.

@itamarst itamarst closed this Mar 3, 2025
@itamarst itamarst reopened this Mar 3, 2025
@itamarst itamarst changed the title fix: Edge case where length 1 Series of array couldn't use index_of() fix: support List/Array in search_sorted(), and fix edge case where length 1 Series of array couldn't use index_of() Mar 3, 2025
@itamarst itamarst changed the title fix: support List/Array in search_sorted(), and fix edge case where length 1 Series of array couldn't use index_of() fix: Support List/Array in search_sorted(), and fix edge case where length 1 Series of array couldn't use index_of() Mar 3, 2025
@itamarst
Copy link
Contributor Author

itamarst commented Mar 3, 2025

@ritchie46 back to you.

@itamarst itamarst requested a review from ritchie46 March 3, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index_of() with Series of length 1 and dtype Array doesn't work
3 participants
@itamarst @ritchie46 @pythonspeed